fix: scroll to bottom when bubble TypingIndicator appears #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chrisallo
reviewed
Dec 19, 2024
| setTypingMembers(channel.getTypingUsers()); | ||
| } | ||
|
|
||
| if (isScrollBottomReached && isContextMenuClosed()) { |
Collaborator
There was a problem hiding this comment.
단순 궁금증인데 isContextMenuClosed() 이거는 어떤 이유에서 체크가 필요한건가요?
Contributor
Author
There was a problem hiding this comment.
유저가 메시지의 메뉴를 열고있는 상태에서 스크롤이 발생하는 동작이 어색하기 때문입니다!
HoonBaek
deleted the
fix/CLNP-6036/bubble-typing-indicator-scroll-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLNP-6036
Issue
ChangeLog