Skip to content

fix: scroll to bottom when bubble TypingIndicator appears #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HoonBaek merged 1 commit into from
Dec 19, 2024
Merged

fix: scroll to bottom when bubble TypingIndicator appears #1289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/modules/GroupChannel/components/MessageList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { GroupChannelUIBasicProps } from '../GroupChannelUI/GroupChannelUIView';
import { deleteNullish } from '../../../../utils/utils';
import { getMessagePartsInfo } from './getMessagePartsInfo';
import { MessageProvider } from '../../../Message/context/MessageProvider';
import { getComponentKeyFromMessage } from '../../context/utils';
import { getComponentKeyFromMessage, isContextMenuClosed } from '../../context/utils';
import { InfiniteList } from './InfiniteList';

export interface GroupChannelMessageListProps {
Expand Down Expand Up @@ -225,13 +225,20 @@ export const MessageList = (props: GroupChannelMessageListProps) => {

const TypingIndicatorBubbleWrapper = (props: { handleScroll: () => void; channelUrl: string }) => {
const { stores } = useSendbirdStateContext();
const { isScrollBottomReached, scrollPubSub } = useGroupChannelContext();
const [typingMembers, setTypingMembers] = useState<Member[]>([]);

useGroupChannelHandler(stores.sdkStore.sdk, {
onTypingStatusUpdated(channel) {
if (channel.url === props.channelUrl) {
setTypingMembers(channel.getTypingUsers());
}

if (isScrollBottomReached && isContextMenuClosed()) {
Copy link
Collaborator

@chrisallo chrisallo Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단순 궁금증인데 isContextMenuClosed() 이거는 어떤 이유에서 체크가 필요한건가요?

Copy link
Contributor Author

@HoonBaek HoonBaek Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유저가 메시지의 메뉴를 열고있는 상태에서 스크롤이 발생하는 동작이 어색하기 때문입니다!
image

setTimeout(() => {
scrollPubSub.publish('scrollToBottom', {});
}, 10);
}
},
});

Expand Down