[SBISSUE-18534] onRecordingEnded Callback Not Triggered #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chrisallo
reviewed
Feb 14, 2025
| } | ||
| }; | ||
| const handleOnControlClick = useCallback(() => { | ||
| const handleOnControlClick = () => { |
Collaborator
There was a problem hiding this comment.
여기서 useCallback을 없내는것도 방법이지만 dependencies에 lastClickTime, onControlClick, setLastClickTime을 추가하는것도 방법이 될 수 있을것 같습니다. 기존에도 아마 lastClickTime이 바뀌었을때에도 오동작을 하고 있었을것같네요.
Contributor
Author
There was a problem hiding this comment.
추후 Generelize해서 논의하는 걸로 결정되었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBISSUE-18534
Changelog
VoiceMessageIssuedoesn't work at the first time.