Skip to content

[SBISSUE-18534] onRecordingEnded Callback Not Triggered #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
git-babel merged 2 commits into from
Feb 14, 2025
Merged

[SBISSUE-18534] onRecordingEnded Callback Not Triggered #1311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f97671f
Fix VoiceMessageInput bug
git-babel Feb 14, 2025
7f5d4a9
Add optional chaning for voiceRecord property
git-babel Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hooks/VoiceRecorder/useVoiceRecorder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const useVoiceRecorder = ({
const { state } = useSendbird();
const { config } = state;
const { voiceRecord } = config;
const maxRecordingTime = voiceRecord.maxRecordingTime;
const maxRecordingTime = voiceRecord?.maxRecordingTime;
const voiceRecorder = useVoiceRecorderContext();
const { isRecordable } = voiceRecorder;

Expand Down
6 changes: 3 additions & 3 deletions src/ui/VoiceMessageInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useCallback, useMemo, useState } from 'react';
import React, { useMemo, useState } from 'react';
import './index.scss';

import PlaybackTime from '../PlaybackTime';
Expand Down Expand Up @@ -63,13 +63,13 @@ export const VoiceMessageInput = ({
setLastClickTime(currentTime);
}
};
const handleOnControlClick = useCallback(() => {
const handleOnControlClick = () => {
Copy link
Collaborator

@chrisallo chrisallo Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 useCallback을 없내는것도 방법이지만 dependencies에 lastClickTime, onControlClick, setLastClickTime을 추가하는것도 방법이 될 수 있을것 같습니다. 기존에도 아마 lastClickTime이 바뀌었을때에도 오동작을 하고 있었을것같네요.

Copy link
Contributor Author

@git-babel git-babel Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후 Generelize해서 논의하는 걸로 결정되었습니다.

const currentTime = Date.now();
if (currentTime - lastClickTime > VOICE_RECORDER_CLICK_BUFFER_TIME) {
onControlClick?.(currentType);
setLastClickTime(currentTime);
}
}, [currentType]);
};
const handleOnSubmitClick = () => {
const currentTime = Date.now();
if (currentTime - lastClickTime > VOICE_RECORDER_CLICK_BUFFER_TIME) {
Expand Down