[CLNP-6813] Set initial value for initialized and loading #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danney-chun
reviewed
May 22, 2025
| fetchChannelError: null, | ||
| nicknamesMap: new Map(), | ||
|
|
||
| initialized: false, |
Contributor
There was a problem hiding this comment.
provide에서 initizlied/loading의 역할이 멀까요?
Collaborator
Author
There was a problem hiding this comment.
UIKit Core에서 넘어온 prop인데요, initialized는 MessageCollection에서 onCacheResult의 결과 messages가 있거나, onApiResult 결과를 받아온 시점에 true가 되구요, loading은 initialized와 값만 반대이고 역할은 거의 동일하나, reset history 할때도 true가 되었다가 처리가 끝나고 false로 바뀌는게 차이가 있습니다.
Contributor
There was a problem hiding this comment.
오~~ SDK에 대한 initialize/loading이 아닌, Collection에 대한 property 이군요..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix]: Set initial value for initialized and loading
iFood 쪽에서 요구한 사항 중 저 플래그 state들의 기본값을 undefined가 아닌 값으로 바꿔달라는 요청이 있어서 작업했습니다.
Fixes CLNP-6813
Changelogs
GroupChannelProviderhasloadingandinitializedflag states as non-undefinedvalueChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.This is a reminder of what we look for before merging your code.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can set up a CLA to allow for the contribution.