Skip to content

[CLNP-6813] Set initial value for initialized and loading #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisallo merged 1 commit into from
May 22, 2025
Merged

[CLNP-6813] Set initial value for initialized and loading #1337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/modules/GroupChannel/context/GroupChannelProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ const initialState = {
fetchChannelError: null,
nicknamesMap: new Map(),

initialized: false,
Copy link
Contributor

@danney-chun danney-chun May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide에서 initizlied/loading의 역할이 멀까요?

Copy link
Collaborator Author

@chrisallo chrisallo May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UIKit Core에서 넘어온 prop인데요, initialized는 MessageCollection에서 onCacheResult의 결과 messages가 있거나, onApiResult 결과를 받아온 시점에 true가 되구요, loading은 initialized와 값만 반대이고 역할은 거의 동일하나, reset history 할때도 true가 되었다가 처리가 끝나고 false로 바뀌는게 차이가 있습니다.

Copy link
Contributor

@danney-chun danney-chun May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오~~ SDK에 대한 initialize/loading이 아닌, Collection에 대한 property 이군요..

loading: true,
messages: [],
quoteMessage: null,
animatedMessageId: null,
Expand Down