Skip to content

[CLNP-5921] Sync thread message with groupchannel message update #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
git-babel merged 1 commit into from
Dec 12, 2024
Merged

[CLNP-5921] Sync thread message with groupchannel message update #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/modules/GroupChannel/context/GroupChannelProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,15 @@ export const GroupChannelProvider = (props: GroupChannelProviderProps) => {
},
);

const messageActions = useMessageActions({ ...props, ...messageDataSource, scrollToBottom, quoteMessage, replyType });
const messageActions = useMessageActions({
...props,
...messageDataSource,
scrollToBottom,
quoteMessage,
replyType,
pubSub: config.pubSub,
channel: currentChannel,
});

return (
<GroupChannelContext.Provider
Expand Down
23 changes: 19 additions & 4 deletions src/modules/GroupChannel/context/hooks/useMessageActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { match } from 'ts-pattern';
import { useCallback } from 'react';
import { useGroupChannelMessages } from '@sendbird/uikit-tools';
import { MessageMetaArray } from '@sendbird/chat/message';
import type {
BaseMessageCreateParams,
FileMessage,
Expand All @@ -12,6 +11,7 @@ import type {
UserMessageCreateParams,
UserMessageUpdateParams,
} from '@sendbird/chat/message';
import { MessageMetaArray } from '@sendbird/chat/message';

import {
META_ARRAY_MESSAGE_TYPE_KEY,
Expand All @@ -20,10 +20,12 @@ import {
VOICE_MESSAGE_FILE_NAME,
VOICE_MESSAGE_MIME_TYPE,
} from '../../../../utils/consts';
import type { SendableMessageType, CoreMessageType } from '../../../../utils';
import type { CoreMessageType, SendableMessageType } from '../../../../utils';
import type { ReplyType } from '../../../../types';
import type { GroupChannelProviderProps, OnBeforeHandler } from '../GroupChannelProvider';
import useSendbirdStateContext from '../../../../hooks/useSendbirdStateContext';
import { PublishingModuleType, PUBSUB_TOPICS, SBUGlobalPubSub } from '../../../../lib/pubSub/topics';
import { GroupChannel } from '@sendbird/chat/groupChannel';

type MessageListDataSource = ReturnType<typeof useGroupChannelMessages>;
type MessageActions = {
Expand All @@ -38,6 +40,8 @@ interface Params extends GroupChannelProviderProps, MessageListDataSource {
scrollToBottom(animated?: boolean): Promise<void>;
quoteMessage?: SendableMessageType | null;
replyType: ReplyType;
pubSub: SBUGlobalPubSub;
channel: GroupChannel;
}

const pass = <T>(value: T) => value;
Expand Down Expand Up @@ -68,6 +72,8 @@ export function useMessageActions(params: Params): MessageActions {
scrollToBottom,
quoteMessage,
replyType,
channel,
pubSub,
} = params;
const { eventHandlers } = useSendbirdStateContext();
const buildInternalMessageParams = useCallback(
Expand Down Expand Up @@ -185,9 +191,18 @@ export function useMessageActions(params: Params): MessageActions {
async (messageId: number, params: UserMessageUpdateParams) => {
const internalParams = buildInternalMessageParams<UserMessageUpdateParams>(params);
const processedParams = await processParams(onBeforeUpdateUserMessage, internalParams, 'update');
return updateUserMessage(messageId, processedParams);
return updateUserMessage(messageId, processedParams)
.then((message) => {
pubSub.publish(PUBSUB_TOPICS.UPDATE_USER_MESSAGE, {
channel,
message,
publishingModules: [PublishingModuleType.CHANNEL],
});

return message;
});
},
[buildInternalMessageParams, updateUserMessage, processParams],
[buildInternalMessageParams, updateUserMessage, processParams, channel?.url],
),
};
}