Skip to content

fix: modified message width in open channel #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HoonBaek merged 3 commits into from
Jan 23, 2025
Merged

fix: modified message width in open channel #1299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3941dd9
modified message width in open channel
HoonBaek Jan 14, 2025
e06eb7a
update test snapshot
HoonBaek Jan 14, 2025
0bd53f1
set using width
HoonBaek Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/modules/OpenChannel/components/OpenChannelMessage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import './open-channel-message.scss';
import React, { useState, useRef, ReactElement } from 'react';
import { AdminMessage, FileMessage, UserMessage } from '@sendbird/chat/message';
import { User } from '@sendbird/chat';
Expand All @@ -8,7 +9,6 @@ import OpenChannelAdminMessage from '../../../../ui/OpenChannelAdminMessage';
import OpenChannelOGMessage from '../../../../ui/OpenchannelOGMessage';
import OpenChannelThumbnailMessage from '../../../../ui/OpenchannelThumbnailMessage';
import OpenChannelFileMessage from '../../../../ui/OpenchannelFileMessage';
// import UnknownMessage from '../../../../ui/UnknownMessage';

import DateSeparator from '../../../../ui/DateSeparator';
import Label, { LabelTypography, LabelColors } from '../../../../ui/Label';
Expand Down Expand Up @@ -73,7 +73,7 @@ export default function OpenChannelMessage(

if (renderMessage) {
return (
<div className="sendbird-msg-hoc sendbird-msg--scroll-ref" data-testid="sendbird-message-hoc">
<div className="sendbird-open-channel-msg-hoc sendbird-msg--scroll-ref" data-testid="sendbird-message-hoc">
{renderMessage({ message, chainTop, chainBottom })}
</div>
);
Expand All @@ -99,7 +99,7 @@ export default function OpenChannelMessage(
}

return (
<div className="sendbird-msg-hoc sendbird-msg--scroll-ref" data-testid="sendbird-message-hoc">
<div className="sendbird-open-channel-msg-hoc sendbird-msg--scroll-ref" data-testid="sendbird-message-hoc">
<>
{/* date-separator */}
{hasSeparator && message?.createdAt && (
Expand Down
3 changes: 3 additions & 0 deletions src/modules/OpenChannel/components/OpenChannelMessage/open-channel-message.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.sendbird-open-channel-msg-hoc {
min-width: 380px;
}
2 changes: 1 addition & 1 deletion src/ui/OpenchannelFileMessage/__tests__/__snapshots__/OpenchannelFileMessage.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ exports[`ui/OpenchannelFileMessage should do a snapshot test of the OpenchannelF
tabindex="0"
>
<span
class="sendbird-label sendbird-label--body-1 sendbird-label--color-onbackground-1"
class="sendbird-openchannel-file-message__right__body__file-name__label sendbird-label sendbird-label--body-1 sendbird-label--color-onbackground-1"
>
72b35fef-acda-4e32-...4-37e1226b0615.pdf
</span>
Expand Down
9 changes: 7 additions & 2 deletions src/ui/OpenchannelFileMessage/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
margin-top: 4px;
margin-bottom: 4px;
border-radius: 8px;
max-width: 360px;
@include themed() {
background-color: t(bg-1);
border: solid 1px t(on-bg-4);
Expand All @@ -79,8 +80,12 @@
overflow: hidden;
height: 20px;
max-height: 20px;
text-overflow: ellipsis;
white-space: nowrap;

.sendbird-openchannel-file-message__right__body__file-name__label {
overflow-x: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}
}
}
}
Expand Down
1 change: 1 addition & 0 deletions src/ui/OpenchannelFileMessage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ export default function OpenChannelFileMessage({
onClick={openFileUrl}
>
<Label
className="sendbird-openchannel-file-message__right__body__file-name__label"
type={LabelTypography.BODY_1}
color={LabelColors.ONBACKGROUND_1}
>
Expand Down
3 changes: 1 addition & 2 deletions src/ui/OpenchannelOGMessage/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@
position: relative;
display: inline-block;
box-sizing: border-box;
width: calc(100% - 64px);
max-width: 360px;
width: 360px;
left: 64px;
padding: 12px 12px 4px 12px;
border-radius: 8px;
Expand Down