Skip to content

[CLNP-6478] tel and mailto to markdown URL protocol #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisallo merged 2 commits into from
Mar 18, 2025
Merged

[CLNP-6478] tel and mailto to markdown URL protocol #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd6678d
add tel and mailto to markdown URL protocol
chrisallo Mar 13, 2025
444d2fb
lint + test fix
chrisallo Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/modules/Message/utils/tokens/__tests__/asSafeUrl.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ describe('asSafeURL', () => {
test('should return the same URL if it is already safe', () => {
expect(asSafeURL('http://example.com')).toBe('http://example.com');
expect(asSafeURL('https://example.com')).toBe('https://example.com');
expect(asSafeURL('mailto:[email protected]')).toBe('mailto:[email protected]');
expect(asSafeURL('tel:+14081234567')).toBe('tel:+14081234567');
});

test('should return a safe URL if it is not safe', () => {
expect(asSafeURL('mailto:[email protected]')).toBe('#');
// eslint-disable-next-line no-script-url
expect(asSafeURL('javascript:alert(1)')).toBe('#');
expect(asSafeURL('javascript%3Aalert%281%29')).toBe('#');
Expand Down
6 changes: 3 additions & 3 deletions src/modules/Message/utils/tokens/asSafeURL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
const supportedProtocols = ['https:', 'http:', 'tel:', 'mailto:'];

export function asSafeURL(url: string) {
let safeURL = decodeURIComponent(url);

try {
const { protocol } = new URL(safeURL);
if (['https:', 'http:'].some((it) => it === protocol.toLowerCase())) {
if (supportedProtocols.some((it) => it === protocol.toLowerCase())) {
return safeURL;
} else {
return '#';
Expand All @@ -13,6 +14,5 @@ export function asSafeURL(url: string) {
safeURL = 'https://' + safeURL;
}
}

return safeURL;
}