Skip to content

Fix undefined error of emojiCategory #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
git-babel merged 3 commits into from
Apr 3, 2025
Merged

Fix undefined error of emojiCategory #1324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c823d2a
Fix undefined error for emojiContainer
git-babel Apr 3, 2025
202fb48
Add empty case UI for EmojiListItems
git-babel Apr 3, 2025
d03be34
Merge branch 'main' into fix/CLNP-6577
git-babel Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/lib/Sendbird/context/SendbirdProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,14 @@ const SendbirdContextManager = ({

// Emoji Manager
const emojiManager = useMemo(() => {
return new EmojiManager({
sdk,
logger,
});
if (sdkStore.initialized) {
return new EmojiManager({
sdk,
logger,
});
}

return undefined;
}, [sdkStore.initialized]);

const uikitConfigs = useMemo(() => ({
Expand Down
3 changes: 1 addition & 2 deletions src/ui/MessageContent/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,7 @@ export function MessageContent(props: MessageContentProps): ReactElement {
message,
channel,
isByMe,
// @ts-ignore
emojiContainer: emojiContainer ?? new EmojiContainer({}),
emojiContainer: emojiContainer,
memberNicknamesMap: nicknamesMap ?? new Map(),
toggleReaction,
onPressUserProfile: onPressUserProfileHandler,
Expand Down
2 changes: 1 addition & 1 deletion src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ export const getEmojiMapAll = (emojiContainer: EmojiContainer): Map<string, Emoj
return emojiMap;
};
export const getEmojiListByCategoryIds = (emojiContainer: EmojiContainer, categoryIds: number[]): Array<Emoji> => {
if (!categoryIds) return getEmojiListAll(emojiContainer);
if (!categoryIds) return getEmojiListAll(emojiContainer) || [];

return emojiContainer?.emojiCategories
?.filter((emojiCategory: EmojiCategory) => categoryIds.includes(emojiCategory.id))
Expand Down