Skip to content

[SBISSUE-18879] scrollToBottom doesn't work when send a message in mobile. #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
git-babel merged 4 commits into from
Apr 15, 2025
Merged

[SBISSUE-18879] scrollToBottom doesn't work when send a message in mobile. #1329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc32d59
Add missing deps list elements
git-babel Apr 10, 2025
aab4525
Add missing dependency 'scrollToBottom'
git-babel Apr 15, 2025
6a361d4
Merge branch 'main' into fix/SBISSUE-18879
git-babel Apr 15, 2025
6a3ffdf
Remove unnecessary delay in `scrollToBottom` callback
git-babel Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/modules/GroupChannel/context/hooks/useGroupChannel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import useSendbird from '../../../../lib/Sendbird/context/hooks/useSendbird';
import { GroupChannelContext } from '../GroupChannelProvider';
import type { GroupChannelState, MessageActions } from '../types';
import { useMessageActions } from './useMessageActions';
import { delay } from '../../../../utils/utils';

export interface GroupChannelActions extends MessageActions {
// Channel actions
Expand Down Expand Up @@ -71,8 +70,6 @@ export const useGroupChannel = () => {
setAnimatedMessageId(null);
setIsScrollBottomReached(true);

// wait a bit for scroll ref to be updated
await delay();
if (config.isOnline && state.hasNext()) {
await state.resetWithStartingPoint(Number.MAX_SAFE_INTEGER);
}
Expand Down
2 changes: 1 addition & 1 deletion src/modules/GroupChannel/context/hooks/useMessageActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export function useMessageActions(params: Params): MessageActions {
() => {
setTimeout(scrollToBottom, 0);
},
[],
[scrollToBottom],
);

const processParams = useCallback(async <T extends keyof MessageParamsByType>(
Expand Down