Skip to content

fix: Mitigate for duplicate email recipients #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Mitigate for duplicate email recipients #1062

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49bfcfd
Update Mail.php
aingelc12ell Oct 15, 2021
257c827
Merge branch 'main' into patch-1
Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions lib/mail/Mail.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,13 @@ class Mail implements \JsonSerializable
/** @var $personalization Personalization[] Messages and their metadata */
private $personalization;

/** @var $emailRecipients monitors unique email addresses in each emailType */
private $emailRecipients = array(
'To' => array(),
'Cc' => array(),
'Bcc' => array()
);

/**
* If passing parameters into this constructor, include $from, $to, $subject,
* $plainTextContent, $htmlContent and $globalSubstitutions at a minimum.
Expand Down Expand Up @@ -198,18 +205,20 @@ private function addRecipientEmail(
&& $emailType === 'To' && $email->isPersonalized()) {
$personalization = new Personalization();
}
if(!in_array($email->getEmailAddress(),$this->emailRecipients[$emailType])){
$this->emailRecipients[$emailType][] = $email->getEmailAddress();
$personalization = $this->getPersonalization($personalizationIndex, $personalization);
$personalization->$personalizationFunctionCall($email);

$personalization = $this->getPersonalization($personalizationIndex, $personalization);
$personalization->$personalizationFunctionCall($email);

if ($subs = $email->getSubstitutions()) {
foreach ($subs as $key => $value) {
$personalization->addSubstitution($key, $value);
if ($subs = $email->getSubstitutions()) {
foreach ($subs as $key => $value) {
$personalization->addSubstitution($key, $value);
}
}
}

if ($email->getSubject()) {
$personalization->setSubject($email->getSubject());
if ($email->getSubject()) {
$personalization->setSubject($email->getSubject());
}
}
}

Expand Down