Fix error on missing method name for android sslpinning disable#772
Merged
IPMegladon merged 1 commit intosensepost:masterfrom Jan 6, 2026
Merged
Fix error on missing method name for android sslpinning disable#772IPMegladon merged 1 commit intosensepost:masterfrom
IPMegladon merged 1 commit intosensepost:masterfrom
Conversation
Collaborator
|
Thanks for the PR, looks good though bit too busy currently to test it. |
VivekMangukiya11
approved these changes
Dec 27, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
android sslpinning disablecommand fails if the class is found, but the target method is unavailable. This PR makes the hooks abort early if the target method isn't available. I've added it to all the ssl pinning hooks to be safe.Error:
Alternatively I could update the catch() logic but that feels a bit weird since we would have to ignore type errors. Or I can throw a custom error, but that feels like overengineering.