📝 Add BLESecurity example #11
Conversation
leon0399
force-pushed
the
feature/ble-security
branch
5 times, most recently
from
0a90a60 to
f687967
Compare
leon0399
force-pushed
the
feature/ble-security
branch
from
f687967 to
6009a40
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new BLE security example demonstrating how to implement secure BLE communication with authentication and encryption features. The example shows how to set up BLE security callbacks, configure encryption settings, and handle passkey authentication.
Key changes:
- Added a complete secure BLE serial communication example with authentication callbacks
- Included CI configuration to build the new secure example
- Demonstrated BLE security features including passkey generation and authentication flow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| examples/SerialToSerialBLE_Secure/SerialToSerialBLE_Secure.ino | New example implementing BLE security with authentication callbacks and encryption |
| .github/workflows/platformio-ci.yml | Added CI build configuration for the new secure BLE example |
| } | ||
|
|
||
| uint32_t onPassKeyRequest(){ | ||
| ESP_LOGI(LOG_TAG, "PassKeyRequest"); |
There was a problem hiding this comment.
LOG_TAG is used but not defined. This will cause a compilation error. Define LOG_TAG as a const char* or use a string literal directly.
| } | ||
|
|
||
| void onPassKeyNotify(uint32_t pass_key){ | ||
| ESP_LOGI(LOG_TAG, "The passkey Notify number: %d", pass_key); |
There was a problem hiding this comment.
LOG_TAG is used but not defined. This will cause a compilation error. Define LOG_TAG as a const char* or use a string literal directly.
| } | ||
|
|
||
| bool onConfirmPIN(uint32_t pass_key){ | ||
| ESP_LOGI(LOG_TAG, "The passkey YES/NO number: %d", pass_key); |
There was a problem hiding this comment.
LOG_TAG is used but not defined. This will cause a compilation error. Define LOG_TAG as a const char* or use a string literal directly.
| } | ||
|
|
||
| bool onSecurityRequest(){ | ||
| ESP_LOGI(LOG_TAG, "SecurityRequest"); |
There was a problem hiding this comment.
LOG_TAG is used but not defined. This will cause a compilation error. Define LOG_TAG as a const char* or use a string literal directly.
| } | ||
|
|
||
| void onAuthenticationComplete(esp_ble_auth_cmpl_t cmpl){ | ||
| ESP_LOGI(LOG_TAG, "Starting BLE work!"); |
There was a problem hiding this comment.
LOG_TAG is used but not defined. This will cause a compilation error. Define LOG_TAG as a const char* or use a string literal directly.
| uint32_t passKey; | ||
|
|
There was a problem hiding this comment.
This global passKey variable appears to be unused since the AppSecurityCallbacks class has its own private passKey member. Consider removing this unused global variable.
| uint32_t passKey; |
|
|
||
| bool onConfirmPIN(uint32_t pass_key){ | ||
| ESP_LOGI(LOG_TAG, "The passkey YES/NO number: %d", pass_key); | ||
| vTaskDelay(5000); |
There was a problem hiding this comment.
The hardcoded 5000ms delay (5 seconds) is a magic number. Consider defining it as a named constant or adding a comment explaining why this specific delay is needed for the confirmation process.
| vTaskDelay(5000); | |
| vTaskDelay(CONFIRMATION_DELAY_MS); |
|
|
||
| BLEServer* pServer = BLEDevice::createServer(); | ||
|
|
||
| BLESecurity *pSecurity = new BLESecurity(); |
There was a problem hiding this comment.
Memory allocated for BLESecurity is never freed, causing a memory leak. Consider using a smart pointer or ensuring proper cleanup, or making it a stack variable if the lifetime permits.
Example of BLESecurity for #8