💚 (GitHub): compile PlatformIO with C++17 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leon0399
force-pushed
the
feature/ci-versions
branch
6 times, most recently
from
141469d to
8e26152
Compare
leon0399
force-pushed
the
feature/ci-versions
branch
11 times, most recently
from
72b0adc to
ec5a40c
Compare
leon0399
force-pushed
the
feature/ci-versions
branch
from
ec5a40c to
68d4f4d
Compare
leon0399
force-pushed
the
feature/ci-versions
branch
from
9ebbb07 to
042e31f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the BLE Serial library to compile with C++17, enabling Class Template Argument Deduction (CTAD) and adds support for NimBLE version 2. The changes improve C++ standard compliance and expand compatibility with different BLE library versions.
Key Changes:
- Adds automatic NimBLE version detection and conditional compilation for version 1 and 2
- Updates examples to use CTAD syntax with fallback comments for older compilers
- Modifies CI workflows to compile with C++17 standard and test multiple BLE library versions
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/BLESerial.h | Adds NimBLE version detection logic and conditional method signatures for different BLE library versions |
| library.properties | Updates library version from 1.1.3 to 1.2.0 |
| library.json | Updates version and changes dependency from "ESP32 BLE Arduino" to "BLE" |
| examples/SerialToSerialBLE_TransparentUART/SerialToSerialBLE_TransparentUART.ino | New example file using CTAD syntax with fallback documentation |
| examples/SerialToSerialBLE_TransparentUART-NimBLE/SerialToSerialBLE_TransparentUART-NimBLE.ino | New NimBLE-specific example with proper property constants |
| examples/SerialToSerialBLE/SerialToSerialBLE.ino | Updates to use CTAD syntax with improved documentation |
| README.md | Fixes badge description from "PlatformIO CI" to "Arduino CI" |
| .github/workflows/platformio-ci.yml | Adds C++17 compilation flags and matrix testing for different NimBLE versions |
| .github/workflows/arduino-ci.yml | Updates to test specific NimBLE versions and improved conditional library inclusion |
| }, | ||
| "dependencies": { | ||
| "ESP32 BLE Arduino": "^2.0.0" | ||
| "BLE": "^2.0.0" |
There was a problem hiding this comment.
The dependency name change from "ESP32 BLE Arduino" to "BLE" may break existing installations and could be ambiguous. Consider keeping the specific library name or providing migration documentation.
Suggested change
| "BLE": "^2.0.0" | |
| "ESP32 BLE Arduino": "^2.0.0" |
| pio ci --lib="." --board=${{ join(matrix.boards, ' --board=') }} ${{ matrix.nimble && format('--project-option="lib_deps=h2zero/NimBLE-Arduino@{0}"', matrix.nimble) || '' }} | ||
| env: | ||
| PLATFORMIO_CI_SRC: "./examples/${{ matrix.example }}/*.ino" | ||
| PLATFORMIO_BUILD_UNFLAGS: | |
There was a problem hiding this comment.
The PLATFORMIO_BUILD_UNFLAGS environment variable appears to be incorrectly indented and may not be properly associated with the build step. It should be indented at the same level as PLATFORMIO_CI_SRC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
Todo
library.jsonandlibrary.propertiesversion