Skip to content

Conversation

@94noni
Copy link
Contributor

@94noni 94noni commented Dec 15, 2025

Q A
Bug fix ? yesish (avoid http call in dev/profiler)
New feature ? no
BC break ? no
Issues Related to #221 (comment)

Description

i propose to add somewhere a doc for this "feature"
friendly ping @Neirda24 do you think it is worth it ? in this file or directly in the readme ?

@Neirda24
Copy link
Contributor

Hello @94noni . You are absolutely right we should have added this file. Although there are several lines to add from v1.0.0...v1.1.0 just a few that comes to mind :

  • sensiolabs_gotenberg.version as you mentionned
  • New way to contribute using Dagger.io
  • Auto configurator for service simplementing BuilderInterface and autoconfigure: true
  • ...

Would you create this file or do you prefer we update this PR ?

@94noni
Copy link
Contributor Author

94noni commented Dec 15, 2025

i do prefer you take over on this PR if possible (more knowledge of the internal) ;)
but indeed having this documented somewhere is to me important to avoid such useless http queries

Copy link
Contributor

@Jean-Beru Jean-Beru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Jean-Beru
Copy link
Contributor

Sorry, I didn't see your message before posting.

New way to contribute using Dagger.io
Auto configurator for service simplementing BuilderInterface and autoconfigure: true

If so, updating this file must be mandatory for each PR that: adds a feature, deprecations, BC breaks, etc. (everything except doc and bugfix)

@Neirda24
Copy link
Contributor

@Jean-Beru : taking over this PR right now. I'll complete the upgrade-1.1 + create the upgrade-1.2 and update the Contributing guide as well.

@Jean-Beru Jean-Beru self-requested a review December 15, 2025 16:35
* Create a new branch for your changes.
* Ensure your code follows the existing style and includes tests if applicable.
* Submit a pull request with a clear description of your changes.
* Update the correct `UPGRADE-*.md` file if it introduce new deprecations, BC breaks or anything that may require changes on developers side.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Update the correct `UPGRADE-*.md` file if it introduce new deprecations, BC breaks or anything that may require changes on developers side.
* Update the correct `UPGRADE-*.md` file if it introduces new deprecations, BC breaks or anything that may require changes on developers side.

# UPGRADE FROM 1.0.0 to 1.1.0

## Configuration Changes
* Added new `sensiolabs_gotenberg.version` to add warning if trying to use a non-yet available feature from Gotenberg.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added new `sensiolabs_gotenberg.version` to add warning if trying to use a non-yet available feature from Gotenberg.
* Added new `sensiolabs_gotenberg.version` to add warning when trying to use a feature not yet available in Gotenberg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants