Allow \SensioLabs\AnsiConverter\AnsiToHtmlConverter to be injected#14
Allow \SensioLabs\AnsiConverter\AnsiToHtmlConverter to be injected#14rquadling wants to merge 1 commit intosensiolabs:masterfrom
Conversation
composer.json
Outdated
| "php": ">=5.3.0" | ||
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^4" |
There was a problem hiding this comment.
That should be removed, I never require phpunit in my composer.json. We can use symfony/phpunit-bridge instead.
There was a problem hiding this comment.
It is require-dev, so isn't part of the deployment requirement. The use case for its presence is for a standalone package. I've not used symfony/phpunit-bridge, so can you show me what this should be please?
There was a problem hiding this comment.
Hi.
I don't know what what should be here if you want to run phpunit in travis.
Having also dropped support for PHP < 7, there's a minimum version of PHPUnit of 6 (it seems).
If you can "fix" this so that the tests are run in travis, then I'd be happy with that.
|
At this stage, I'd be dropping PHP 5.3. It IS end of life and I wonder if the tests ever passed. If a new major release was created for this PR, then that would be the time to drop 5.3 (and maybe 5.4 also). |
|
@fabpot Any idea on what I can do for the failing unit tests on PHP 5.3? Also, can you give me some more info on the PHPUnit issue in the |
|
Testing the regex against one of the unit tests ansi encoded strings. Output for 5.4.0 - 5.6.30, hhvm-3.10.1 - 3.19.0, 7.0.0 - 7.1.4 is all OK Output for 4.3.0 - 5.3.29 fails In further examination, this seems to be due to PHP <5.4 not understanding escape in a string. At this stage, I'd say dropping PHP < 5.4 is a reasonable proposition. |
5267f08 to
c7587fa
Compare
As a consequence, the need to be able to set a theme at run time, rather than at compile time is necessary. Also added PHPUnit require-dev support and added tests to show the theme can be injected and overridden.
aa1294f to
667d0c4
Compare
As a consequence, the need to be able to set a theme at run time, rather
than at compile time is necessary.
Also added PHPUnit require-dev support and added tests to show the theme
can be injected and overridden.