Conversation
Signed-off-by: Sean Porter <portertech@gmail.com>
Signed-off-by: Sean Porter <portertech@gmail.com>
Signed-off-by: Sean Porter <portertech@gmail.com>
Signed-off-by: Sean Porter <portertech@gmail.com>
Signed-off-by: Sean Porter <portertech@gmail.com>
Signed-off-by: Sean Porter <portertech@gmail.com>
|
|
|
Deploying an RC gem build and doing some testing. |
|
|
majormoses
left a comment
majormoses
left a comment
There was a problem hiding this comment.
Overall looks good have one question about losing an existing feature that I think could be implemented and needs a changelog entry.
Let's also get a changelog entry under:
## [Unreleased]
### Breaking Changes
- ...
| long: '--pattern PATTERN', | ||
| description: 'A PATTERN to detect outliers' | ||
|
|
||
| option :honor_stash, |
There was a problem hiding this comment.
should we have honor_silence? I get that the api calls have been changed with the rename but I think we can still provide the same functionality right?
There was a problem hiding this comment.
Rework would be necessary to capture the client and check associated with particular named aggregate results (which probably requires a bunch of assumptions).
There was a problem hiding this comment.
OK, we just need to call that out as one of the breaking changes in the changelog then.
2 participants
Updated the Sensu Check Aggregate plugins for Sensu 1.x. This pull-request drops support for Sensu < 0.24.0, supporting only named aggregates.
Closes #19