Skip to content

Fallback Pipelines#5118

Open
rakibhossainctr wants to merge 29 commits intodevelop/6from
fallback-experiment
Open

Fallback Pipelines#5118
rakibhossainctr wants to merge 29 commits intodevelop/6from
fallback-experiment

Conversation

@rakibhossainctr
Copy link

@rakibhossainctr rakibhossainctr commented Jul 16, 2025 •
edited
Loading

What is this change?

  1. Updating agent events to carry FallbackPipeline to backend
  2. Updating GetAssets to raise errors on missing runtime assets

Why is this change necessary?

When the execution of a workflow pipe handler results in an error (e.g. fork/exec failure), the error is logged and any other workflows in the pipeline are skipped. This does not include pipe handlers that return a non-zero exit status. The AdapterV1 Pipeline Adapter does not currently distinguish between zero and non-zero exit statuses. The remaining workflows are also skipped if the execution of a filter or mutator results in an error.

Does your change need a Changelog entry?

NA

Do you need clarification on anything?

NA

Were there any complications while making this change?

  • refactoring was required

Have you reviewed and updated the documentation for this change? Is new documentation required?

NA

How did you verify this change?

  1. Created handler with non-zero status (wrong command) and verified

Is this change a patch?

NA

@rakibhossainctr rakibhossainctr linked an issue Aug 4, 2025 that may be closed by this pull request
Stop execution of asset consumers if asset.GetAssets() or asset.GetAll() errors #4407
Open
@chavakula
Copy link

chavakula commented Aug 5, 2025

@rakibhossainctr test cases are failing, please check

@chavakula
Copy link

chavakula commented Aug 5, 2025

@rakibhossainctr need to add latest core/V2 version in go.mod

@rakibhossainctr
added basic structure for new fallack pipelines's adapter
da0b98e 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
configured backend with new fallback pipelines adapter
6aa33f2 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
configured pipelined to handle fallback pipeline with available adapter
27d1e6d 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
added some basic method in fallback pipelines adapter
9f4cded 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
completed mutate, handle and filter method for fallback pipelines
2714dfb 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
separated each file in it's correct location
3f77079 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
added basic structure code to retrieve fallback pipelines from etcd
2a6d3af 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
added fallback pipelines fetching code from etcd
bb97a27 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
fixed pipelines return statement from getFallbackPipelinesFromStore
abb2d11 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
removed fallback pipeline adapter from sensu-go and stored common ada…
fdc1685 
…pter

Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
changed pipeline getter pattern
446fd83 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
changed the panic statement
88ab3b3 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
deleted fallback pipelines store
d4a20b6 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
removed traces from proxy store
a917bc1 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
changed the resource getter pattern
b1d5e1d 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
fixed logger in pipelined
1819335 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
fixed the fallback pipeline refer
89df026 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
added continue on error on existing pipeline and changed non-zero han…
73af2b3 
…dler execution as error

Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
raised error on missing runtime asset
9661edd 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
reviewed proper documentation
25c3d60 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
updating go.mod for testing purposes
c967ef6 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
fguimond
fguimond reviewed Aug 14, 2025
View reviewed changes
@rakibhossainctr
updating changelog
e30f271 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
updating go.mod after resolving merge conflict
69cf327 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
Merge branch 'develop/6' into fallback-experiment
38648c7
@rakibhossainctr
updating core module in go.mod
b2050c1 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
updating change log
9450fe3 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
static check workflow fix
24cc478 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
amdprophet
amdprophet approved these changes Feb 2, 2026
View reviewed changes
Copy link
Member

@amdprophet amdprophet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@rakibhossainctr
updating go version in appveyor
71cd9d7 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
@rakibhossainctr
updating go downloadable url for appveyor
4ff59c7 
Signed-off-by: rakibhossainctr <rakib.hossain.ctr@sumologic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amdprophet amdprophet amdprophet approved these changes

@chavakula chavakula Awaiting requested review from chavakula

@paragchak-sumo paragchak-sumo Awaiting requested review from paragchak-sumo

+1 more reviewer

@fguimond fguimond fguimond left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stop execution of asset consumers if asset.GetAssets() or asset.GetAll() errors

4 participants

@rakibhossainctr @chavakula @amdprophet @fguimond