build(deps): bump tar and npm in /next#1294
Open
dependabot[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
dependabot
bot
added
dependencies
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Removes [tar](https://github.com/isaacs/node-tar). It's no longer used after updating ancestor dependency [npm](https://github.com/npm/cli). These dependencies need to be updated together. Removes `tar` Updates `npm` from 10.8.2 to 11.10.1 - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@v10.8.2...v11.10.1) --- updated-dependencies: - dependency-name: tar dependency-version: dependency-type: indirect - dependency-name: npm dependency-version: 11.10.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/next/multi-3a7252cfc1
branch
from
d39ba64 to
136e258
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
17393
to
17400
| "npm": "bin/npm-cli.js", | ||
| "npx": "bin/npx-cli.js" | ||
| }, | ||
| "engines": { | ||
| "node": "^18.17.0 || >=20.5.0" | ||
| "node": "^20.17.0 || >=22.9.0" | ||
| } | ||
| }, | ||
| "node_modules/npm-run-path": { |
Contributor
There was a problem hiding this comment.
Bug: The Docker build will fail because the node:18 image specified in the Dockerfile is incompatible with the new npm version's Node.js engine requirement (^20.17.0).
Severity: CRITICAL
Suggested Fix
Update the FROM instruction in the next/Dockerfile to use a Node.js version compatible with npm v11.10.1. For example, change FROM node:18-buster-slim to FROM node:20-buster-slim or a more recent compatible version.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: next/package-lock.json#L17393-L17400
Potential issue: The `package-lock.json` file was updated to use npm v11.10.1, which
requires Node.js version `^20.17.0` or `>=22.9.0`. However, the `next/Dockerfile` is
configured to use the `node:18-buster-slim` image. When the Docker image is built, the
`npm ci` command will execute in a Node.js 18 environment. This will cause an engine
incompatibility error, preventing dependencies from being installed and causing the
entire build process to fail. This will block any new deployments of the application.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes tar. It's no longer used after updating ancestor dependency npm. These dependencies need to be updated together.
Removes
tarUpdates
npmfrom 10.8.2 to 11.10.1Release notes
Sourced from npm's releases.
... (truncated)
Changelog
Sourced from npm's changelog.
... (truncated)
Commits
c029cb2chore: release 11.10.19fac412fix: improve unknown config warning with .npmrc section hint (#8995)aa8ffbfdeps: init-package-json@8.2.5 (#9002)67a0f09deps: glob@13.0.656b8fd4deps: minimatch@10.2.2aa7fef5deps: minipass@7.1.3d3a4161deps:@npmcli/package-json@7.0.5 (#9000)0a5756ddocs: clarify unsupported custom .npmrc keys and recommend alternatives (#8998)bb135ccfix(arborist): fixpeerOptionaldependency resolution inbuildIdealTree(...7aa9338deps: remove cli-columnsMaintainer changes
This version was pushed to npm by owlstronaut, a new releaser for npm since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.