Skip to content

Comments

[react,next,angular,tda] Rename checkout transactions and components for clarity + update metrics prefixes#1307

Open
maxkosty wants to merge 5 commits intomasterfrom
checkout-rename-to-checkout-form
Open

[react,next,angular,tda] Rename checkout transactions and components for clarity + update metrics prefixes#1307
maxkosty wants to merge 5 commits intomasterfrom
checkout-rename-to-checkout-form

Conversation

@maxkosty
Copy link
Collaborator

@maxkosty maxkosty commented Feb 24, 2026

Goal

  1. Make the meaning of /checkout (now /checkout-form) transaction more clear and avoid confusion with BE /checkout (== place order, corresponds to FE Submit Checkout Form )
  2. Rename Submit Checkout From -> checkout_submit so it can be used as prefix for metrics
  3. Make names of span attributes and metrics more consistent

Side Effects

  • must update any CExp dashboard
  • data in CExp dashboard will be incomplete for next 24 hours until we get enough historic data with this new txn name

Testing

./deploy react angular --env=local
cd next && vercel dev

/ -> /products -> add to cart -> /checkout-form -> checkout_submit -> /error works as expected

@maxkosty maxkosty requested a review from ndmanvar as a code owner February 24, 2026 21:50
@vercel
Copy link
Contributor

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
empower Ready Ready Preview, Comment Feb 25, 2026 0:14am

Request Review

@maxkosty maxkosty force-pushed the checkout-rename-to-checkout-form branch from 9fe142d to adb19d2 Compare February 24, 2026 23:54
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.05%. Comparing base (8e777c9) to head (5d6b16a).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
react/src/components/CheckoutForm.jsx 7.69% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1307   +/-   ##
=======================================
  Coverage   22.05%   22.05%           
=======================================
  Files          42       42           
  Lines        1360     1360           
  Branches      175      175           
=======================================
  Hits          300      300           
  Misses       1034     1034           
  Partials       26       26           
Flag Coverage Δ
api 5.83% <ø> (ø)
frontend 32.44% <7.69%> (ø)
Components Coverage Δ
checkout_module 5.83% <ø> (ø)
product_component 25.93% <7.69%> (ø)
Files with missing lines Coverage Δ
react/src/components/Cart.jsx 100.00% <ø> (ø)
react/src/index.js 0.00% <ø> (ø)
react/src/components/CheckoutForm.jsx 15.65% <7.69%> (ø)

@maxkosty maxkosty changed the title [react,next,tda] rename FE /checkout -> /checkout-form [react,next,tda] Rename checkout transactions and components for clarity + update metrics prefixes Feb 25, 2026
@maxkosty maxkosty changed the title [react,next,tda] Rename checkout transactions and components for clarity + update metrics prefixes [react,next,angular,tda] Rename checkout transactions and components for clarity + update metrics prefixes Feb 25, 2026
Comment on lines 340 to 348
></Route>
<Route path="/cart" element={<Cart />} />
<Route
path="/checkout"
path="/checkout-form"
element={
<Checkout
<CheckoutForm
backend={BACKEND_URL}
rageclick={RAGECLICK}
checkout_success={CHECKOUT_SUCCESS}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The Vue.js application was missed in this update, causing it to use a different checkout route and Sentry transaction name than the other frontend frameworks.
Severity: MEDIUM

Suggested Fix

Update the Vue.js application to match the changes in the other frameworks. This includes changing the route path in vue/src/router/index.js to /checkout-form, updating navigation links in vue/src/App.vue and vue/src/views/ProductsView.vue, and changing the transaction name in vue/src/views/CheckoutView.vue to "checkout_submit".

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: react/src/index.js#L340-L348

Potential issue: The Vue.js application was not updated to align with changes made to
the React, Angular, and Next.js applications. This pull request updates the checkout
route and Sentry transaction names for other frameworks but omits Vue. As a result, the
Vue application will continue to use the old route (`/checkout` instead of
`/checkout-form`) and send transactions with the old name (`"Checkout"` instead of
`"checkout_submit"`). This will cause data inconsistencies in monitoring dashboards, as
Vue's metrics will not match the other frontend applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant