fix(react): Safely validate inventory in ProductCard#1330
Draft
sentry[bot] wants to merge 1 commit intomasterfrom
Draft
fix(react): Safely validate inventory in ProductCard#1330sentry[bot] wants to merge 1 commit intomasterfrom
sentry[bot] wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1330 +/- ##
==========================================
- Coverage 22.01% 22.01% -0.01%
==========================================
Files 42 42
Lines 1349 1363 +14
Branches 174 176 +2
==========================================
+ Hits 297 300 +3
- Misses 1026 1036 +10
- Partials 26 27 +1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes REACT-60Z. The issue was that:
inventoryisundefinedbecauseaddToCartJsErrorflag, set bycexpquery parameter, intentionally causes it.inventoryvariable before calling.includes()invalidate_inventoryto prevent potential runtime errors.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 10075049
Not quite right? Click here to continue debugging with Seer.