Fix NameError in /checkout endpoint - define quantities before use#1382
Draft
cursor[bot] wants to merge 1 commit intomasterfrom
Draft
Fix NameError in /checkout endpoint - define quantities before use#1382cursor[bot] wants to merge 1 commit intomasterfrom
cursor[bot] wants to merge 1 commit intomasterfrom
Conversation
Fixes FRONTEND-REACT-6B1 The checkout endpoint was throwing a NameError because the 'quantities' variable was used in a conditional check before it was defined. This caused HTTP 500 errors during checkout. Moved the quantities definition (line 228) before its usage (line 225) to resolve the issue.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (22.01%) is below the target coverage (35.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1382 +/- ##
=======================================
Coverage 22.01% 22.01%
=======================================
Files 42 42
Lines 1363 1363
Branches 176 176
=======================================
Hits 300 300
Misses 1036 1036
Partials 27 27
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes FRONTEND-REACT-6B1
This PR fixes a critical bug in the Flask backend's
/checkoutendpoint that was causing HTTP 500 errors during checkout.Problem
The
quantitiesvariable was being used in a conditional check (line 225) before it was defined (line 228), causing aNameErrorexception whenvalidate_inventorywas true.Solution
Moved the
quantitiesdefinition before its usage in the validation logic.Changes
quantitiesbefore checking its lengthTesting
The fix resolves the NameError that was preventing successful checkout operations. The checkout flow now properly:
Related Issues