Fix NameError in checkout endpoint - Fixes ANDROID-DN#1388
Draft
cursor[bot] wants to merge 1 commit intomasterfrom
Draft
Fix NameError in checkout endpoint - Fixes ANDROID-DN#1388cursor[bot] wants to merge 1 commit intomasterfrom
cursor[bot] wants to merge 1 commit intomasterfrom
Conversation
Fixes ANDROID-DN The checkout endpoint was attempting to check len(quantities) before quantities was assigned, causing a NameError and 500 response. This error propagated to the Android app which threw BackendAPIException. Fixed by moving the quantities assignment from line 228 to line 225, before the length check.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1388 +/- ##
=======================================
Coverage 22.01% 22.01%
=======================================
Files 42 42
Lines 1363 1363
Branches 176 176
=======================================
Hits 300 300
- Misses 1036 1037 +1
+ Partials 27 26 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Flask backend's
/checkoutendpoint was causing aNameErrorby attempting to use thequantitiesvariable before it was defined. This resulted in:MainFragment$BackendAPIException: Failed to init delivery workflowRoot Cause
In
flask/src/main.pyline 225, the code checkedlen(quantities)beforequantitieswas assigned on line 228:Solution
Moved the
quantitiesassignment before the length check:Impact
NameErrorBackendAPIExceptiondue to this backend errorTesting
✅ Python syntax validation passed
✅ Logic verification test passed
✅ The fix addresses the order-of-operations issue
When a checkout request is made with
validate_inventory: true, the endpoint will now: