Dispatch long file operations and product processing to background threads#107
Draft
seer-by-sentry[bot] wants to merge 1 commit intomasterfrom
Draft
Dispatch long file operations and product processing to background threads#107seer-by-sentry[bot] wants to merge 1 commit intomasterfrom
seer-by-sentry[bot] wants to merge 1 commit intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
=============================================
- Coverage 37.877% 36.148% -1.730%
=============================================
Files 10 10
Lines 1027 1054 +27
Branches 323 342 +19
=============================================
- Hits 389 381 -8
- Misses 629 663 +34
- Partials 9 10 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IOS-4. The issue was that: Synchronous, recursive CPU-bound Fibonacci calculations and extensive recursive file I/O operations on the main thread during
viewDidLoadcaused app hanging.performLongFileOperation,processProducts, andreadCurrentDirectoryfunctions to background threads usingDispatchQueue.global(qos: .background).async.This fix was generated by Seer in Sentry, triggered by Rohan Agarwal. 👁️ Run ID: 53579