Skip to content

nft_storage removed#261

Merged
sadrasabouri merged 13 commits intodevfrom
nft_storage
May 21, 2025
Merged

nft_storage removed#261
sadrasabouri merged 13 commits intodevfrom
nft_storage

Conversation

@sepandhaghighi
Copy link
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • nft_storage method removed
  • Gateway enum removed
  • demo.ipynb updated
  • Test system modified

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this May 21, 2025
@sepandhaghighi sepandhaghighi added this to the samila v1.6 milestone May 21, 2025
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (3aa970c) to head (f5cf92a).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #261      +/-   ##
==========================================
+ Coverage   99.47%   99.86%   +0.39%     
==========================================
  Files           4        4              
  Lines         753      679      -74     
  Branches      113      105       -8     
==========================================
- Hits          749      678      -71     
+ Misses          2        0       -2     
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi sepandhaghighi marked this pull request as ready for review May 21, 2025 16:02
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it's sad to see NFT storage's going.

@sadrasabouri sadrasabouri merged commit f88d5e5 into dev May 21, 2025
18 checks passed
@sadrasabouri sadrasabouri deleted the nft_storage branch May 21, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants