Skip to content

Update taxi zebra flake and add new python version#152

Merged
sephii merged 1 commit intosephii:mainfrom
jocelynthode:update-zebra-build-nix
Jul 13, 2025
Merged

Update taxi zebra flake and add new python version#152
sephii merged 1 commit intosephii:mainfrom
jocelynthode:update-zebra-build-nix

Conversation

@jocelynthode
Copy link
Contributor

@jocelynthode jocelynthode commented Jul 8, 2025

  • Update flake and cleanup structure
  • Update taxi zebra to latest 5.0.0
  • Remove Python < 3.10 (3.9 support ends in 3 months)
  • Add Build with all plugins steps to make sure their flake definition is ok

@jocelynthode jocelynthode marked this pull request as draft July 8, 2025 06:25
@jocelynthode jocelynthode force-pushed the update-zebra-build-nix branch 2 times, most recently from 9a80210 to b6ed6de Compare July 8, 2025 06:37
@jocelynthode jocelynthode marked this pull request as ready for review July 8, 2025 06:44
@jocelynthode
Copy link
Contributor Author

Hey @sephii it should be ready to review 🙂

Copy link
Owner

@sephii sephii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you please put the formatting changes (and the addition of a formatter) in a separate PR? Changes to the formatting make the review harder. Also I usually use nixfmt-rfc-style, which tries to follow RFC 166. I’d suggest using nixfmt-rfc-style unless you see a reason to use alejandra instead.

@jocelynthode jocelynthode force-pushed the update-zebra-build-nix branch from 953ed50 to ce1f473 Compare July 12, 2025 11:35
@jocelynthode jocelynthode requested a review from sephii July 12, 2025 11:37
@jocelynthode
Copy link
Contributor Author

I’ve removed alejandra and the formatter in the flake. I’ll submit a PR later when this one is done to use nixfmt-rfc-style. I’m just used to alejandra in my projects from before the RFC, but have no objection using nixfmt.

I’ve tried to revert as much as possible the formatter changes.

@jocelynthode jocelynthode force-pushed the update-zebra-build-nix branch 3 times, most recently from 923bb30 to 743b8fd Compare July 13, 2025 10:01
@jocelynthode jocelynthode force-pushed the update-zebra-build-nix branch from 743b8fd to e275a11 Compare July 13, 2025 10:06
@jocelynthode jocelynthode requested a review from sephii July 13, 2025 10:09
@sephii sephii merged commit 29b50a3 into sephii:main Jul 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants