[MISC] Use cpp23 #3313
Merged
[MISC] Use cpp23 #3313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seqan-actions
added
lint
Member
|
Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3313 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3313 +/- ##
==========================================
- Coverage 98.13% 98.11% -0.03%
==========================================
Files 271 271
Lines 11954 11914 -40
Branches 104 104
==========================================
- Hits 11731 11689 -42
- Misses 223 225 +2 ☔ View full report in Codecov by Sentry. |
seqan-actions
added
lint
seqan-actions
added
lint
seqan-actions
added
lint
sharg still adds -std=c++20 which overwrites seqan3's -std=c++23 flag. This can be removed once sharg uses CMake for std-detection
seqan-actions
added
lint
rrahn
approved these changes
Dec 13, 2024
Contributor
rrahn
left a comment
rrahn
left a comment
There was a problem hiding this comment.
As far as I can tell, this looks good to me.
SGSSGene
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.