[FIX,TEST] Do not check zlib output for alternative implementations #3324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seqan-actions
added
lint
eseiler
commented
Jan 21, 2025
| if constexpr (TestFixture::zero_out_os_byte) | ||
| { | ||
| buffer[9] = '\x00'; // zero-out the OS byte. | ||
| SEQAN3_TEST_GTEST_SKIP_ZLIB_DEFLATE; |
Member
Author
There was a problem hiding this comment.
The template is also used for bz2, which we don't want to skip.
zero_out_os_byte (also used for istream template) is currently equivalent to is_zlib_compression.
Member
|
Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3324 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3324 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 271 271
Lines 11923 11923
Branches 104 104
=======================================
Hits 11698 11698
Misses 225 225 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3323