Skip to content

Conversation

@eseiler
Copy link
Member

@eseiler eseiler commented Mar 6, 2025

CPM usually does a find_package redirect.
If find_package is called for some package added via CPM, it is redirected to CPM.

Before CPM 0.40.6, there was a bug that prevented this redirection from working properly.

If Seqan3 is added via CPM, CPM will call seqan3's CMakeLists.txt.
Because we use find_package there, it is redirected and results in seqan3 not being available.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Mar 6, 2025
@eseiler eseiler force-pushed the fix/find_package branch from 35fb1ff to 4c6f31d Compare March 6, 2025 18:12
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Mar 6, 2025
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3345

@eseiler eseiler force-pushed the fix/find_package branch from 4c6f31d to 26c5cbe Compare March 6, 2025 18:28
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Mar 6, 2025
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (d48a8c3) to head (26c5cbe).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3345      +/-   ##
==========================================
- Coverage   98.12%   98.11%   -0.01%     
==========================================
  Files         270      270              
  Lines       11915    11913       -2     
  Branches      103      103              
==========================================
- Hits        11691    11689       -2     
  Misses        224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eseiler eseiler merged commit 9a07fdb into seqan:main Mar 6, 2025
40 checks passed
@eseiler eseiler deleted the fix/find_package branch March 6, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants