Skip to content

[FIX] Bogus warning on gcc-15 with hardened flags #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eseiler merged 1 commit into from
Mar 24, 2025
Merged

[FIX] Bogus warning on gcc-15 with hardened flags #3350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions test/unit/search/search_scheme_algorithm_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,18 +128,13 @@ inline void test_search_hamming(auto index,

auto remove_predicate_ss = [&text, &orig_query, query_length](uint64_t const hit)
{
seqan3::dna4_vector matched_seq =
text | seqan3::views::slice(hit, hit + query_length) | seqan3::ranges::to<seqan3::dna4_vector>();
return (matched_seq != orig_query);
return !std::ranges::equal(orig_query, seqan3::views::slice(text, hit, hit + query_length));
};

auto remove_predicate_trivial = [&](uint64_t const hit)
{
// filter only correct error distributions
seqan3::dna4_vector matched_seq =
text | seqan3::views::slice(hit, hit + query_length) | seqan3::ranges::to<seqan3::dna4_vector>();

if (orig_query != matched_seq)
if (!std::ranges::equal(orig_query, seqan3::views::slice(text, hit, hit + query_length)))
return true;

uint64_t lb = 0, rb = 0;
Expand Down