Merge pull request #269 from eseiler/fix/codechecker2

[FIX] More codechecker checks

Author: eseiler

doc/howto/custom_types/custom_type.cpp

@@ -48,7 +48,7 @@ int main(int argc, char const ** argv)
         return -1;
     }
 
-    std::cout << "my_bar was initialised with a = " << my_bar.a << std::endl;
+    std::cout << "my_bar was initialised with a = " << my_bar.a << '\n';
 
     return 0;
 }

doc/howto/custom_types/external_custom_type.cpp

@@ -52,7 +52,7 @@ int main(int argc, char const ** argv)
         return -1;
     }
 
-    std::cout << "ext_bar was initialised with a = " << ext_bar.a << std::endl;
+    std::cout << "ext_bar was initialised with a = " << ext_bar.a << '\n';
 
     return 0;
 }

include/sharg/auxiliary.hpp

@@ -22,7 +22,7 @@ namespace sharg
  * \details
  * \stableapi{Since version 1.0.}
  */
-enum class update_notifications
+enum class update_notifications : uint8_t
 {
     on, //!< Automatic update notifications should be enabled.
     off //!< Automatic update notifications should be disabled.

include/sharg/detail/format_parse.hpp

@@ -199,7 +199,7 @@ class format_parse : public format_base
 
 private:
     //!\brief Describes the result of parsing the user input string given the respective option value type.
-    enum class option_parse_result
+    enum class option_parse_result : uint8_t
     {
         success,       //!< Parsing of user input was successful.
         error,         //!< There was some error while trying to parse the user input.
@@ -605,7 +605,7 @@ class format_parse : public format_base
     {
         for (auto it = arguments.begin(); it != end_of_options_it; ++it)
         {
-            std::string arg{*it};
+            std::string & arg{*it};
             if (!arg.empty() && arg[0] == '-') // may be an identifier
             {
                 if (arg == "-")

include/sharg/detail/format_tdl.hpp

@@ -89,7 +89,7 @@ inline auto to_tdl(std::string const & v)
 }
 
 //!\copydetails sharg::detail::to_tdl
-auto to_tdl(auto SHARG_DOXYGEN_ONLY(v))
+auto to_tdl(auto SHARG_DOXYGEN_ONLY(v)) // NOLINT(performance-unnecessary-value-param)
 {
     return tdl::BoolValue(false);
 }
@@ -106,7 +106,7 @@ class format_tdl : format_base
 {
 public:
     //!\brief Supported tool description file formats.
-    enum class FileFormat
+    enum class FileFormat : uint8_t
     {
         CTD, //!<Support for CTD format
         CWL, //!<Support for CWL format
@@ -324,11 +324,11 @@ class format_tdl : format_base
         meta = parser_meta;
 
         // each call will evaluate the function print_list_item()
-        for (auto f : positional_option_calls)
+        for (auto && f : positional_option_calls)
             f(meta.app_name);
 
         // each call will evaluate the function print_list_item()
-        for (auto f : parser_set_up_calls)
+        for (auto && f : parser_set_up_calls)
             f(meta.app_name);
 
         info.metaInfo = tdl::MetaInfo{

include/sharg/parser.hpp

@@ -178,24 +178,24 @@ class parser
      * \details
      * \stableapi{Since version 1.0.}
      */
-    parser(std::string const & app_name,
-           std::vector<std::string> const & arguments,
+    parser(std::string app_name,
+           std::vector<std::string> arguments,
            update_notifications version_updates = update_notifications::on,
-           std::vector<std::string> subcommands = {}) :
+           std::vector<std::string> const & subcommands = {}) :
         version_check_dev_decision{version_updates},
-        arguments{arguments}
+        arguments{std::move(arguments)}
     {
-        add_subcommands(std::move(subcommands));
-        info.app_name = app_name;
+        add_subcommands(subcommands);
+        info.app_name = std::move(app_name);
     }
 
     //!\overload
-    parser(std::string const & app_name,
+    parser(std::string app_name,
            int const argc,
            char const * const * const argv,
            update_notifications version_updates = update_notifications::on,
-           std::vector<std::string> subcommands = {}) :
-        parser{app_name, std::vector<std::string>{argv, argv + argc}, version_updates, std::move(subcommands)}
+           std::vector<std::string> const & subcommands = {}) :
+        parser{std::move(app_name), std::vector<std::string>{argv, argv + argc}, version_updates, subcommands}
     {}
 
     //!\brief The destructor.

include/sharg/validators.hpp

@@ -246,7 +246,7 @@ class value_list_validator
     {
         std::for_each(std::ranges::begin(range),
                       std::ranges::end(range),
-                      [&](auto cmp)
+                      [&](auto && cmp)
                       {
                           (*this)(cmp);
                       });
@@ -353,7 +353,7 @@ class file_validator_base
     {
         std::for_each(v.begin(),
                       v.end(),
-                      [&](auto cmp)
+                      [&](auto && cmp)
                       {
                           this->operator()(cmp);
                       });
@@ -414,7 +414,8 @@ class file_validator_base
         if (std::filesystem::is_directory(path))
         {
             std::error_code ec{};
-            std::filesystem::directory_iterator{path, ec}; // if directory iterator cannot be created, ec will be set.
+            // if directory iterator cannot be created, ec will be set.
+            std::filesystem::directory_iterator{path, ec}; // NOLINT(bugprone-unused-raii)
             if (static_cast<bool>(ec))
                 throw validation_error{"Cannot read the directory \"" + path.string() + "\"!"};
         }

test/include/sharg/test/test_fixture.hpp

@@ -50,12 +50,9 @@ class test_fixture : public ::testing::Test
 private:
     friend class early_exit_guardian;
 
-    static sharg::parser impl(std::vector<std::string> arguments, std::vector<std::string> subcommands = {})
+    static sharg::parser impl(std::vector<std::string> arguments, std::vector<std::string> const & subcommands = {})
     {
-        sharg::parser parser{"test_parser",
-                             std::move(arguments),
-                             sharg::update_notifications::off,
-                             std::move(subcommands)};
+        sharg::parser parser{"test_parser", std::move(arguments), sharg::update_notifications::off, subcommands};
         sharg::detail::test_accessor::set_terminal_width(parser, 80u);
         return parser;
     }
@@ -69,10 +66,11 @@ class test_fixture : public ::testing::Test
         return impl(std::vector<std::string>{"./test_parser", std::forward<arg_ts>(arguments)...});
     }
 
-    static sharg::parser get_subcommand_parser(std::vector<std::string> arguments, std::vector<std::string> subcommands)
+    static sharg::parser get_subcommand_parser(std::vector<std::string> arguments,
+                                               std::vector<std::string> const & subcommands)
     {
         arguments.insert(arguments.begin(), "./test_parser");
-        return impl(std::move(arguments), std::move(subcommands));
+        return impl(std::move(arguments), subcommands);
     }
 
     static std::string get_parse_cout_on_exit(sharg::parser & parser)
@@ -238,7 +236,7 @@ class early_exit_guardian
     };
 };
 
-early_exit_guardian early_exit_guard{};
+early_exit_guardian early_exit_guard{}; // NOLINT(misc-definitions-in-headers)
 
 inline void test_fixture::toggle_guardian()
 {

test/snippet/custom_enumeration.cpp

@@ -7,7 +7,7 @@
 namespace foo
 {
 
-enum class bar
+enum class bar : uint8_t
 {
     one,
     two,

test/unit/detail/format_help_test.cpp

@@ -373,7 +373,7 @@ TEST_F(format_help_test, advanced_options)
     EXPECT_EQ(get_parse_cout_on_exit(parser), expected);
 }
 
-enum class foo
+enum class foo : uint8_t
 {
     one,
     two,