Skip to content

Conversation

@eseiler
Copy link
Member

@eseiler eseiler commented Mar 6, 2025

CPM usually does a find_package redirect.
If find_package is called for some package added via CPM, it is redirected to CPM.

Before CPM 0.40.6, there was a bug that prevented this redirection from working properly.

If sharg is added via CPM, CPM will call sharg 's CMakeLists.txt.
Because we use find_package there, it is redirected and results in sharg not being available.

@seqan-actions seqan-actions added lint [INTERNAL] signals that clang-format ran and removed lint [INTERNAL] signals that clang-format ran labels Mar 6, 2025
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (e9bc14b) to head (fb9bf00).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          18       18           
  Lines        1738     1738           
  Branches       44       44           
=======================================
  Hits         1647     1647           
  Misses         91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/sharg-parser/262

@eseiler eseiler force-pushed the fix/find_package branch from a207298 to fb9bf00 Compare March 6, 2025 18:29
@seqan-actions seqan-actions added lint [INTERNAL] signals that clang-format ran and removed lint [INTERNAL] signals that clang-format ran labels Mar 6, 2025
@eseiler eseiler merged commit da92d23 into seqan:main Mar 6, 2025
36 checks passed
@eseiler eseiler deleted the fix/find_package branch March 6, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants