-
Notifications
You must be signed in to change notification settings - Fork 1
Add Xpra and IGV (v2.19.4) Java desktop example #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
xpra-igv/Dockerfile
Outdated
| # Install IGV | ||
| ARG igv_version=IGV_Linux_2.19.4 | ||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| software-properties-common \ | ||
| default-jre \ | ||
| unzip \ | ||
| lsof \ | ||
| glib-networking-common && \ | ||
| mkdir -p /igv && \ | ||
| cd /igv && \ | ||
| wget "https://data.broadinstitute.org/igv/projects/downloads/2.19/${igv_version}_WithJava.zip" && \ | ||
| unzip ${igv_version}_WithJava.zip && \ | ||
| cd ${igv_version} && \ | ||
| cd /usr/bin && \ | ||
| ln -s /igv/${igv_version}/igv.sh ./igv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we already have mamba (right?) couldn't this just be mamba install igv? Any of the deps above that relate to IGV rather than xpra (if any) could then also be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - will update and pin to a specific IGV version.
Co-authored-by: Robert Syme <[email protected]>
Co-authored-by: Robert Syme <[email protected]>
…stom-studios-examples into robnewman-xpra-igv
|
@pinin4fjords Mamba installing IGV is throwing ugly errors. You seen these before? |
Co-authored-by: Robert Syme <[email protected]>
robsyme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tidy. Nice work, Rob.
|
@pinin4fjords Any ideas here? It looks like the |
Surely it must get symlinked in somewhere. @robnewman - what is the output of which igvDoes this directory exist? |
Yep, I don't think it will work to create a new env as you're doing (as least not without getting very fiddly), just update the base env with |
|
Sorry, this comment might be really annoying at this point. But I'm wondering if we actually need to re-create the Seqera Xpra image here? Maybe we could demo how to augment the existing one? |
@pinin4fjords But then this repo will need to be updated every time a new Seqera-managed container is released, correct? |
I was kind of worried about the same thing in the other direction. This has a lot of the same content as the internal xpra Dockerfile, so if you have cause to change how the xpra image is built internally, we'll need to keep all that content in synch. Plus we'll probably need to update for new connect base images anyway, at least this way it would just be the base image. Anyway, just a suggestion. |

Already tested and working in Seqera's staging container registry environment