Rewrite lib-data-stream-redis production code from Groovy to Java #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts all production source files in
lib-data-stream-redisfrom Groovy to pure Java while keeping tests in Groovy/Spock. This removes the Groovy runtime dependency from production code.Files converted
AbstractMessageStream.groovyAbstractMessageStream.javaMessageConsumer.groovyMessageConsumer.javaMessageStream.groovyMessageStream.javaimpl/LocalMessageStream.groovyimpl/LocalMessageStream.javaimpl/RedisMessageStream.groovyimpl/RedisMessageStream.javaimpl/RedisStreamConfig.groovyimpl/RedisStreamConfig.javaKey Groovy-to-Java conversions
@Slf4jannotationprivate static final Logger log = LoggerFactory.getLogger(...)@CompileStatic@Memoized"${var}"String.format()defkeyword?.?:finallocal varsfinalor mutable varsreturninfinallyblock (suppresses exceptions)Note on exception handling in
LocalMessageStream.consume()In Groovy, having
return resultinside afinallyblock suppresses any exception thrown in thetry/catchblock. The original code relied on this behavior to catch consumer exceptions and returnfalseinstead of propagating the exception.In Java, this was converted to explicitly catch the exception without rethrowing:
build.gradle changes
io.seqera.groovy-library-conventionspluginimplementationtotestImplementationgroovyplugin for test compilation (Spock tests remain in Groovy)Test plan
🤖 Generated with Claude Code