Enable using external run logs with nf-aggregate#89
Merged
Conversation
FloWuenne
requested review from
ejseqera and
maxulysse
and removed request for
maxulysse
maxulysse
approved these changes
Apr 17, 2025
maxulysse
suggested changes
Apr 17, 2025
Contributor
maxulysse
left a comment
maxulysse
left a comment
There was a problem hiding this comment.
don't we need to update the tests to reflect this new feature?
Where is the new pipeline test with external run logs?
Contributor
Author
|
Yeah will have to update tests to also include the benchmark reports. I will add a second samplesheet that uses external and internal logs to compile a benchmark report. That way, we test all the new features in one go! |
Contributor
Author
|
@maxulysse I have updated the tests and they now include an example for using local logs with the benchmark report. I turned off gannt and multiqc for the local reports, because for these processes, we need to supply the reports as folders, not tarballs. |
Contributor
|
@FloWuenne I have an idea, let's talk about it later |
maxulysse
approved these changes
Apr 30, 2025
Contributor
|
Nice hack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following features & updates to nf-aggregate: