Important! Template update for nf-core/tools v3.3.1#96
Merged
Conversation
maxulysse
commented
Jun 9, 2025
maxulysse
commented
Jun 9, 2025
Contributor
Author
|
Only lingering issues are: |
Contributor
Author
|
BTW, I squeeze in an alphabetical sort order |
maxulysse
commented
Jun 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the nf-core/templates and related testing infrastructure to support nf-aggregate v3.3.1, including updates to snapshot files, configuration files, and GitHub Actions workflows. Key changes include:
- Refreshing test snapshots and updating test configurations (nf-test.config, default tests) to align with the new template.
- Updating URL references from api.tower.nf to api.cloud.seqera.io and bumping the nf-core template version.
- Introducing new workflow profiles (e.g. gpu) and adding/updating GitHub Actions workflows and custom actions for nf-test.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/main.nf.test.snap, tests/default.nf.test.snap, tests/default.nf.test | Updated test snapshots and assertions for consistency with v3.3.1 |
| subworkflows/local/utils_nf_aggregate/tests/main.nf.test.snap | Updated run IDs and workspace values to the new naming scheme |
| ro-crate-metadata.json | Updated metadata such as datePublished and template references |
| nf-test.config | Modified workDir source and ignore triggers; bumped plugin version |
| nextflow.config | Added a GPU profile with appropriate runOptions |
| modules/local/seqera_runs_dump/tests/* | Updated input values to reflect domain and workspace changes |
| modules/local/plot_run_gantt/tests/main.nf.test, modules/local/benchmark_report/tests/main.nf.test | Updated domain URLs in test inputs |
| assets/multiqc_report.html, README.md | Updated URL references and nf-core template version links |
| .prettierrc.yml, .nf-core.yml | Minor configuration tweaks and version bumps |
| .github/workflows/nf-test.yml, .github/actions/*, .github/CONTRIBUTING.md | Added new nf-test workflows and custom actions; removed legacy CI workflow |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:1
- The legacy CI workflow file is removed in this PR. Please confirm that all necessary tests are now covered by the new nf-test workflow to avoid any gaps in the CI process.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
Contributor
Author
|
Still seeing |
Contributor
|
@maxulysse The new nf-test ci/cd was simply missing the env TOWER_ACCESS_TOKEN! |
FloWuenne
approved these changes
Jun 17, 2025
Contributor
Author
good catch 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).