Open
Conversation
gavinelder
force-pushed
the
wave-docs-update
branch
from
f735165 to
9f8485a
Compare
christopher-hakkaart
approved these changes
Mar 23, 2026
Member
There was a problem hiding this comment.
I've started going through this, but the suggestions I was making were larger structural changes or specific language changes outside the scope of this PR, which, IMO, is to add missing explanations/details and ensure the content is correct.
@gwright99 and I are talking about Wave install and configuration later this week. In the interest of having everything on the table and in place so we can work with a single set of docs rather than multiple in-flight PRs, I think the best approach is to push forward with this with minimal suggestions and catch everything else in a second iteration, e.g., think about the best place for troublshooting and faq content
| This guide covers extending your existing Wave installation on Kubernetes to support container build capabilities. This enables Wave's full feature set including container building, freezing, and advanced caching. | ||
| This guide covers extending your existing Wave installation on Kubernetes to support container build capabilities. This enables Wave's full feature set, including container building, freezing, security scanning, mirroring, and advanced caching. | ||
|
|
||
| Wave builds use a **two-namespace architecture**: the main Wave application runs in one namespace (e.g., `wave`) and spawns ephemeral build, scan, and mirror pods in a dedicated build namespace (e.g., `wave-build`). Both namespaces share a single EFS filesystem so that build artifacts are accessible to both the app and the build pods. |
Member
There was a problem hiding this comment.
Suggested change
| Wave builds use a **two-namespace architecture**: the main Wave application runs in one namespace (e.g., `wave`) and spawns ephemeral build, scan, and mirror pods in a dedicated build namespace (e.g., `wave-build`). Both namespaces share a single EFS filesystem so that build artifacts are accessible to both the app and the build pods. | |
| Wave builds use a **two-namespace architecture**. The main Wave application runs in one namespace (e.g., `wave`) and spawns ephemeral build, scan, and mirror pods in a dedicated build namespace (e.g., `wave-build`). Both namespaces share a single EFS filesystem, allowing build artifacts to be accessible to both the application and the build pods. |
Comment on lines
+9
to
+25
| ``` | ||
| ┌──────────────────────────┐ ┌───────────────────────────────┐ | ||
| │ Namespace: wave │ │ Namespace: wave-build │ | ||
| │ │ │ │ | ||
| │ Wave app (Deployment) │────►│ Build pods (ephemeral) │ | ||
| │ Schedules build pods │ │ Scan pods (ephemeral) │ | ||
| │ via K8s API │ │ Mirror pods (ephemeral) │ | ||
| │ │ │ │ | ||
| │ PVC: wave-app-fs ──┐ │ │ PVC: wave-build-fs ──┐ │ | ||
| └──────────────────────┼───┘ └────────────────────────┼──────┘ | ||
| │ │ | ||
| └──────────┬───────────────────────┘ | ||
| ▼ | ||
| ┌─────────────────────┐ | ||
| │ AWS EFS filesystem │ | ||
| │ (shared storage) │ | ||
| └─────────────────────┘ |
Member
There was a problem hiding this comment.
Do you object if I turn this into a mermaid?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following updates the docs based on deploys...