fix: move to trusted publishing #1551
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,96 +1,67 @@ | ||
| name: CI | ||
| on: pull_request | ||
|
|
||
| jobs: | ||
| test-postgres: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [10, 24] | ||
| sequelize-version: [5, latest] | ||
| name: Postgres (Node ${{ matrix.node-version }}, Sequelize ${{ matrix.sequelize-version }}) | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| DIALECT: postgres | ||
| SEQ_PORT: 54320 | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: if [ "${{ matrix.node-version }}" = "10" ]; then npm install -g npm@7; fi | ||
| - run: npm ci | ||
| - run: npm install sequelize@${{ matrix.sequelize-version }} | ||
| - run: docker compose up -d ${DIALECT} | ||
| - run: docker run --link ${DIALECT}:db --net cli_default jwilder/dockerize -wait tcp://${DIALECT}:${SEQ_PORT::-1} -timeout 2m | ||
| - run: npm test | ||
|
Member
There was a problem hiding this comment. while i dont mind, why are we moving to npm=
Member
Author
There was a problem hiding this comment. Because yarn doesn't offer the trusted publishing (yet). So we're locking in to the npm registry and its package manager |
||
| test-mysql: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [10, 24] | ||
| sequelize-version: [5, latest] | ||
| name: MySQL (Node ${{ matrix.node-version }}, Sequelize ${{ matrix.sequelize-version }}) | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| DIALECT: mysql | ||
| SEQ_PORT: 33060 | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: if [ "${{ matrix.node-version }}" = "10" ]; then npm install -g npm@7; fi | ||
| - run: npm ci | ||
| - run: npm install sequelize@${{ matrix.sequelize-version }} | ||
| - run: docker compose up -d ${DIALECT} | ||
| - run: docker run --link ${DIALECT}:db --net cli_default jwilder/dockerize -wait tcp://${DIALECT}:${SEQ_PORT::-1} -timeout 2m | ||
| - run: npm test | ||
| test-sqlite: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [10, 24] | ||
| sequelize-version: [5, latest] | ||
| name: SQLite (Node ${{ matrix.node-version }}, Sequelize ${{ matrix.sequelize-version }}) | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| DIALECT: sqlite | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: if [ "${{ matrix.node-version }}" = "10" ]; then npm install -g npm@7; fi | ||
| - run: npm ci | ||
| - run: npm install sequelize@${{ matrix.sequelize-version }} | ||
| - run: npm test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| name: Release | ||
| on: workflow_dispatch | ||
|
|
||
| permissions: | ||
| contents: read # for checkout | ||
|
|
||
| jobs: | ||
| release: | ||
| name: Release | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write # to be able to publish a GitHub release | ||
| issues: write # to be able to comment on released issues | ||
| pull-requests: write # to be able to comment on released pull requests | ||
| id-token: write # to enable use of OIDC for trusted publishing and npm provenance | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 'lts/*' | ||
| - name: Install dependencies | ||
| run: npm clean-install | ||
| - name: Verify the integrity of provenance attestations and registry signatures for installed dependencies | ||
| run: npm audit signatures | ||
| - name: Release | ||
| id: release | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: npm run release | ||
| - name: Post release notes to OpenCollective | ||
| if: steps.release.outputs.new_release_published == 'true' | ||
| env: | ||
| OPENCOLLECTIVE_TOKEN: ${{ secrets.OPEN_COLLECTIVE_KEY }} | ||
| OPENCOLLECTIVE_SLUG: sequelize | ||
| RELEASE_VERSION: ${{ steps.release.outputs.new_release_version }} | ||
| RELEASE_NOTES: ${{ steps.release.outputs.new_release_notes }} | ||
| PACKAGE_NAME: sequelize-cli | ||
| run: | | ||
| curl -X POST "https://api.opencollective.com/graphql/v2" \ | ||
|
Member
There was a problem hiding this comment. does this mean we dont need the dispatch job anymore that i created a few years ago? |
||
| -H "Content-Type: application/json" \ | ||
| # TODO: use OAuth instead of Personal-Token so we can create the updates from the organization instead of a user | ||
|
Member
Author
There was a problem hiding this comment. Now when we post something to OpenCollective it's done under your name. With OAuth we should be able to do it under the name of the organization. This is a TODO for a later PR |
||
| -H "Personal-Token: $OPENCOLLECTIVE_TOKEN" \ | ||
| -d "{ | ||
| \"query\": \"mutation CreateUpdate(\$update: UpdateCreateInput!) { createUpdate(update: \$update) { id legacyId slug title html publishedAt } }\", | ||
| \"variables\": { | ||
| \"update\": { | ||
| \"account\": { | ||
| \"slug\": \"$OPENCOLLECTIVE_SLUG\" | ||
| }, | ||
| \"title\": \"Release of $PACKAGE_NAME $RELEASE_VERSION\", | ||
| \"html\": \"<h2>Release of $PACKAGE_NAME $RELEASE_VERSION</h2><p>We've just released version $RELEASE_VERSION of $PACKAGE_NAME!</p><h3>Changes:</h3><pre>$RELEASE_NOTES</pre><p>Install it with: <code>npm install $PACKAGE_NAME@$RELEASE_VERSION</code></p>\", | ||
| \"isPrivate\": false, | ||
| \"notificationAudience\": \"ALL\" | ||
| } | ||
| } | ||
| }" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,5 +27,5 @@ test/support/tmp/* | |
| !test/support/tmp/.gitkeep | ||
|
|
||
| # Extra files | ||
| yarn.lock | ||
| npm-debug.log | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does this migrate from on push to on pull_request?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't run it 'on push' at the regular repo, so this makes it more consistent. Reasoning there was because we do everything with PRs that are up to date, we don't need to run it again after merging