Skip to content

Added missing dialects to fix ts compile with sequelize 6.29. #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added missing dialects to fix ts compile with sequelize 6.29. #642

wants to merge 1 commit into from

Conversation

hhowe29
Copy link

@hhowe29 hhowe29 commented Mar 11, 2023

  • Added null dialects for db2, oracle, and snowflake
  • Refactored code to obtain dialect through a helper function
  • Throw an error if the selected dialect is not implemented.

Fixes #641

@hhowe29 hhowe29 force-pushed the fix_build_error_from_new_dialect_types branch from 57273ab to 38668a0 Compare March 11, 2023 21:34
@ghost ghost mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New dialects in sequelize 6.x break the ts build in sequelize-auto
1 participant
@hhowe29