Skip to content

Conversation

@ephys
Copy link
Member

@ephys ephys commented Nov 16, 2024

This is an alternative implementation of #755 that adds the graph of npm-compare to the front-page instead of to the documentation

Closes #755

@ephys ephys requested a review from a team as a code owner November 16, 2024 21:48
@ephys ephys requested review from WikiRik and sdepold November 16, 2024 21:48
@ephys ephys mentioned this pull request Nov 16, 2024
@cwtuan
Copy link

cwtuan commented Feb 17, 2025

Is there anything I can assist with regarding this PR?

<h2>Trusted and used by thousands</h2>
<div className={styles.usageGraphs}>
<figure>
<a href="https://npm-compare.com/sequelize#timeRange=THREE_YEARS" target="_blank">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://npm-compare.com/sequelize#timeRange=THREE_YEARS" target="_blank">
<a href="https://npm-compare.com/sequelize#timeRange=THREE_YEARS" target="_blank" rel="noreferrer">

</figure>

<figure>
<a href="https://npm-compare.com/@sequelize/core#timeRange=THREE_YEARS" target="_blank">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://npm-compare.com/@sequelize/core#timeRange=THREE_YEARS" target="_blank">
<a href="https://npm-compare.com/@sequelize/core#timeRange=THREE_YEARS" target="_blank" rel="noreferrer">

@LitoMore
Copy link

LitoMore commented Mar 10, 2025

@WikiRik
Copy link
Member

WikiRik commented Mar 10, 2025

Thanks for that heads-up! @LitoMore

I indeed read the conversation there (do note that that repo is private and we should be mindful on how much we share links to it on a public repo), but in this case the website does provide a service that we like. I'll look around what possible alternatives are, but we've interacted well with the creator so we likely will give it the benefit of the doubt for now

Edit; it seems that the original PR is not accessible anymore, so I can't easily show you that conversation. Which also does impact my argument

@WikiRik WikiRik closed this Mar 10, 2025
@WikiRik WikiRik deleted the ephys/npm-usage branch March 10, 2025 18:16
@cwtuan
Copy link

cwtuan commented Jul 21, 2025

Hi, I'm the creator of npm-compare.

I understand that my account was likely potentially fraudulent because of the numerous pull requests I sent to promote my website, npm-compare.com. I sincerely apologize for any inconvenience this might have caused.

My intention behind creating npm-compare was to offer a valuable tool to the developer community. Eager to share it globally, I made the error of over - promoting it through mass pull requests.

I now recognize my mistake, understanding that this behavior not only disrupted project maintainers but also violated GitHub's rules. I've learned from this experience. Going forward, I will strictly adhere to GitHub's guidelines and use only proper channels to promote my projects.

I have now deleted the promotional pull requests. I once again apologize for any disruption my actions may have caused.

I deeply appreciate the work you all do, and I don’t want to add to your burden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants