✨ Windmill: Add Postgres-Backed Integration Tests for SQL Logic#2518
Open
✨ Windmill: Add Postgres-Backed Integration Tests for SQL Logic#2518
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an automated SQL regression test for Windmill’s “latest cast vote per voter” query by introducing a Postgres bootstrapping helper and wiring the ignored test into CI.
Changes:
- Introduces
TestDatabasehelper to bootstrap a Postgres DB by extracting devcontainer init SQL and applying Hasura backend migrations. - Refactors
find_area_ballotsSQL construction into a helper that validates UUID inputs, and adds an integration test asserting latest vote selection per voter. - Adds a dedicated GitHub Actions job to run the ignored SQL regression test; updates
.gitignore.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
packages/windmill/src/test_database.rs |
New test-only Postgres bootstrap utility (init SQL extraction + migrations + optional local Postgres process). |
packages/windmill/src/services/cast_votes.rs |
Adds UUID-validating SQL builder for the COPY query and an ignored integration test using TestDatabase. |
packages/windmill/src/lib.rs |
Exposes test_database module under #[cfg(test)]. |
.github/workflows/tests.yml |
Adds CI job to run the ignored Windmill SQL regression test with a Postgres service container. |
.gitignore |
Normalizes airgapped-artifacts ignore and adds beyond/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/11564