tx pool: don't drop cxns relaying key images spent in chain#204
Open
j-berman wants to merge 2 commits intoseraphis-migration:fcmp++-stagefrom
Open
tx pool: don't drop cxns relaying key images spent in chain#204j-berman wants to merge 2 commits intoseraphis-migration:fcmp++-stagefrom
j-berman wants to merge 2 commits intoseraphis-migration:fcmp++-stagefrom
Conversation
This was referenced Oct 30, 2025
Collaborator
|
Needs updating to match #207 |
Co-authored-by: Jeffro <jeffro256@tutanota.com>
j-berman
force-pushed
the
no-drop-dbl-spend
branch
from
3aaa895 to
a09e4e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assume a reorg of Tx A out the chain back into the pool (or Tx A is just normally relayed to a node), and then a new Block B comes along that includes Tx B spending the same output(s) as Tx A.
Nodes currently will attempt to re-relay Tx A even though its output(s) are spent in the chain. If a node receives Tx A from another node, it will drop the connection (1, 2, 3).
Since it's possible for an honest node that hasn't seen the new block B to attempt to relay Tx A to a node that has already seen Block B, this PR changes this to a no-drop-offense. The honest node's connection will continue processing any other txs the honest node relayed to it here.