Get multisig working pre-FCMP++/Carrot fork#291
Draft
j-berman wants to merge 1 commit intoseraphis-migration:fcmp++-stagefrom
Draft
Get multisig working pre-FCMP++/Carrot fork#291j-berman wants to merge 1 commit intoseraphis-migration:fcmp++-stagefrom
j-berman wants to merge 1 commit intoseraphis-migration:fcmp++-stagefrom
Conversation
Reuse the background sync cache for multisig sync, so that upon importing multisig info, the wallet doesn't need to rescan the chain and instead can just process the background cache.
j-berman
force-pushed
the
multisig-bg-sync
branch
from
603ed2f to
27db6ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuses the background sync cache for multisig sync, so that upon importing multisig info, the wallet doesn't need to rescan the chain and instead can just process the background cache. This change is upstream-able.
This is a required change for a FCMP++ compatible wallet because with the existing impl (before this PR), the wallet may rescan the chain from many blocks below chain tip. With FCMP++, the wallet can't pop more than n blocks (100 is the default) because the pruned curve tree cannot go back that far, it has a max depth.
I'm planning to look into porting @kayabaNerve's drop-in compatible multisig next, building on top of this draft.