Inline serde_core into serde in docsrs mode #2991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2608 regressed the rustdoc rendered documentation of
serdein many ways because rustdoc does not currently handle documentation of cross-crate re-exported items well. For example there is not enough information in the rmeta of dependencies to accurately reconstruct the way that trait associated types are named in signatures. The A-cross-crate-reexports label in rust-lang/rust records numerous other issues.Before #2608:
After #2608:
This PR works around the cross-crate re-export issues by inlining the items defined by
serde_coreintoserdewhen building documentation for docs.rs.