Add WASI support for OsStr/OsString serialization#3036
Closed
veeceey wants to merge 1 commit intoserde-rs:masterfrom
Closed
Add WASI support for OsStr/OsString serialization#3036veeceey wants to merge 1 commit intoserde-rs:masterfrom
veeceey wants to merge 1 commit intoserde-rs:masterfrom
Conversation
Extends the existing Unix and Windows implementations to include WASI targets. WASI uses Unix-like OsStrExt API, so it follows the same serialization pattern as Unix, encoding OsStr as bytes using the "Unix" variant. Fixes serde-rs#3020
Member
Obviously you did not
AI spammer, banning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3020
This PR extends the OsStr/OsString Serialize/Deserialize implementations to support WASI targets.
WASI provides Unix-like OsStrExt APIs (same as std::os::unix::ffi::OsStrExt but under std::os::wasi::ffi), so the implementation follows the same pattern as Unix - serializing as bytes using the "Unix" variant.
Changes
any(unix, windows)toany(unix, windows, target_family = "wasi")std::os::wasi::ffi::OsStrExtTesting
Tested by verifying the code compiles for WASI targets (wasip1/p2) which previously failed.