Upgrades #84
Merged
Upgrades #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub Actions workflow dependencies and the libsodium library version. The changes modernize CI/CD infrastructure by upgrading to newer versions of GitHub Actions, standardizing quote styles in YAML files, and updating the libsodium minisig file to version 1.0.20.
- Updates GitHub Actions dependencies (
actions/checkoutfrom v3 to v5,actions/cachefrom v2/v3 to v4,actions/upload-artifactfrom v3 to v4,actions/setup-nodefrom v3 to v5/v6) - Updates libsodium minisig file to version 1.0.20
- Standardizes YAML quote style from single quotes to double quotes in several workflow files
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libsodium/libsodium-1.0.20-stable.tar.gz.minisig | Updates the minisig signature file for libsodium 1.0.20 |
| CONTRIBUTING.md | Updates documentation example to reference libsodium version 1.0.20 |
| .github/workflows/e2e-web.yml | Upgrades GitHub Actions versions and pins ubuntu-22.04, adds explicit Node.js LTS setup |
| .github/workflows/e2e-ios.yml | Updates actions/checkout from v3 to v5 and actions/cache from v2 to v4 |
| .github/workflows/e2e-android.yml | Updates actions/checkout from v3 to v5 and actions/cache from v2 to v4 |
| .github/workflows/ci.yml | Updates actions/checkout from v3 to v5 and standardizes quote style for Python version |
| .github/workflows/build-ios.yml | Updates actions/checkout from v3 to v5 and actions/cache from v2 to v4 |
| .github/workflows/build-android.yml | Updates actions/checkout from v3 to v5, actions/cache from v2 to v4, and standardizes quote style |
| .github/actions/setup/action.yml | Updates actions/setup-node from v3 to v6 and actions/cache from v3 to v4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### Upgrade Libsodium c library | ||
|
|
||
| Download a the new minisig file e.g. `libsodium-1.0.19-stable.tar.gz.minisig` to `./libsodium`. Update the version in `./libsodium/build.sh` and run `cd libsodium && ./build.sh` to build the new library. | ||
| Download a the new minisig file e.g. `libsodium-1.0.20-stable.tar.gz.minisig` to `./libsodium`. Update the version in `./libsodium/build.sh` and run `cd libsodium && ./build.sh` to build the new library. |
There was a problem hiding this comment.
Grammatical error: 'Download a the' should be 'Download the' (remove the redundant 'a').
Suggested change
| Download a the new minisig file e.g. `libsodium-1.0.20-stable.tar.gz.minisig` to `./libsodium`. Update the version in `./libsodium/build.sh` and run `cd libsodium && ./build.sh` to build the new library. | |
| Download the new minisig file e.g. `libsodium-1.0.20-stable.tar.gz.minisig` to `./libsodium`. Update the version in `./libsodium/build.sh` and run `cd libsodium && ./build.sh` to build the new library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.