Add proxy support for websocket connect#3449
Open
Morb0 wants to merge 1 commit intoserenity-rs:currentfrom
Open
Add proxy support for websocket connect#3449Morb0 wants to merge 1 commit intoserenity-rs:currentfrom
Morb0 wants to merge 1 commit intoserenity-rs:currentfrom
Conversation
github-actions
bot
added
client
arqunis
added
enhancement
arqunis
requested changes
Dec 11, 2025
| #[cfg(feature = "voice")] | ||
| pub voice_manager: Option<Arc<dyn VoiceGatewayManager>>, | ||
| pub ws_url: Arc<Mutex<String>>, | ||
| pub ws_proxy: Arc<Mutex<Option<String>>>, |
| /// TLS error. | ||
| pub async fn new( | ||
| ws_url: Arc<Mutex<String>>, | ||
| ws_proxy: Arc<Mutex<Option<String>>>, |
Member
There was a problem hiding this comment.
[...] and this are breaking changes. Would you mind if you retargeted the PR to the next branch?
| token, | ||
| seq, | ||
| }, | ||
| d: WebSocketMessageData::Resume { session_id, token, seq }, |
Member
There was a problem hiding this comment.
Unrelated formatting change. This can happen if you're running the stable version of Rustfmt, since we use a few nightly-only options.
Suggested change
| d: WebSocketMessageData::Resume { session_id, token, seq }, | |
| d: WebSocketMessageData::Resume { | |
| session_id, | |
| token, | |
| seq, | |
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue of #2709
Fix #2479