Revert ShardRunner refactor/simplification#3506
Open
GnomedDev wants to merge 2 commits intoserenity-rs:nextfrom
Open
Revert ShardRunner refactor/simplification#3506GnomedDev wants to merge 2 commits intoserenity-rs:nextfrom
GnomedDev wants to merge 2 commits intoserenity-rs:nextfrom
Conversation
github-actions
bot
added
model
Collaborator
|
I have a PR that supersedes this almost ready, which moves dispatch back into per-shard tasks but keeps the cleanup to |
Member
Author
|
Fair enough, just opening this in case others need it as a known good configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes all events to be dispatched from a single thread, which caused a single core to hang at 100% when deploying to 1.1m guilds. I am not quite sure the exact performance hotspot, but the general idea of dispatching all events from the ShardManager is a bad idea.
This is running on TTS Bot now.