Fix YoutubeDl by updating yt-dlp format syntax#283
Open
mincomk wants to merge 2 commits intoserenity-rs:nextfrom
Open
Fix YoutubeDl by updating yt-dlp format syntax#283mincomk wants to merge 2 commits intoserenity-rs:nextfrom
yt-dlp format syntax#283mincomk wants to merge 2 commits intoserenity-rs:nextfrom
Conversation
Member
|
Is this still relevant, at least according to the man page for the latest release the old way is allowed, and is more or less equivalent to what you proposed. https://man.archlinux.org/man/extra/yt-dlp/yt-dlp.1.en#FORMAT_SELECTION |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #245, which caused YouTube playback to fail due to recent changes in
yt-dlpbehavior.Changed the
yt-dlpformat parameter (-f) to appropriate form to fixFiring Erroroccurred onYoutubeDlplayback.